Use new POST :batchDelete callbacks #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ains/, /api/clients, and /api/lists and remove some code duplication along the way. Also ensure that the "Default" group cannot be selected for deletion (we already suppress the trash button for this entry) Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
commented
Dec 7, 2023
| @@ -561,35 +561,35 @@ function listAlert(type, items, data) { | |||
| // Show a list of successful items if there are any | |||
| if (data.processed.success.length > 0) { | |||
| message += | |||
| "<strong>Successfully added " + | |||
There was a problem hiding this comment.
This and further HTML tags are removed as this string is later HTML-encoded ans they have been appearing in the toast as plain text. This is already broken in development-v6 right now.
|
I started to test the PR and it works with Groups, Clients and Domains... But it failed with Lists: I can delete single items (red thrash can button). |
rdwebdesign
previously approved these changes
Dec 11, 2023
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: Dominik <DL6ER@users.noreply.github.com>
rdwebdesign
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Use new special
POST :batchDeletecallbacks for/api/groups,/api/domains,/api/clients, and/api/listsand remove some code duplication along the way.Also ensure that the "Default" group cannot be selected for deletion (we already suppress the trash button for this entry).
Need FTL from pi-hole/FTL#1810
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.